Client upgrade - bugfix progress thread

PkHonor's work in progress and future updates will be posted here.
User avatar
Mike
Programmer
Posts: 6297
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Client upgrade - bugfix progress thread

Post by Mike » Tue Nov 01, 2016 10:39 pm

For the next couple of weeks, I won't be posting much on the news thread in regards to the bughunter contest. Instead, I'll be reporting on my bugfixing progress on this devblog thread instead, for a better overview. Bughunters can keep on reporting their bugs on the news thread - I'll make sure to include all of them on my to-do list.


The first thing for me to do however, was making sure the testserver was up to date with our current production server. Since the testserver uses the completely reworked OSRS content, it took me some work to integrate the latest production changes (in regards to the halloween event & their rewards, as well as a few minor bugfixes from the last couple of days) into the testserver.
The fact that every single update I currently perform on the production server also needs to be applied to the testserver means I'm doing a a lot of double work. It's manageable, but it also means we're rather limited in regards to the updates we can bring to the production server until we have released the new major update.

In any case, that's all done now, so the testserver currently contains every single feature of our current production server and integrating the testserver changes into production later on should happen seamlessly.


I'll keep you posted on my progress in regards to the bugfixes on this thread ;)

User avatar
The underdog
Premium Donator
Posts: 6480
Joined: Sun Jan 26, 2014 11:53 pm
Location: Loc
Contact:

Re: Client upgrade - bugfix progress thread

Post by The underdog » Wed Nov 02, 2016 1:52 am

Now I can finally do the Halloween event on the testserver! ;)
#Justice4Church

User avatar
Mike
Programmer
Posts: 6297
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Wed Nov 02, 2016 2:50 am

The underdog wrote:Now I can finally do the Halloween event on the testserver! ;)
Actually, you can't. The only thing I implemented on the testserver was the ability to reobtain lost items, but the event itself - nor the purple sweets - can be done. I did this on purpose, considering the halloween event will be over by the time we release the major update (my current goal is near the end of November, but we'll see how long all these bugs take me to fix). Saved me a lot of time on the merger.

Srczm
Premium Donator
Posts: 32
Joined: Mon Sep 23, 2013 4:37 pm

Re: Client upgrade - bugfix progress thread

Post by Srczm » Wed Nov 02, 2016 9:12 pm

great work sir

User avatar
Mike
Programmer
Posts: 6297
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Mon Nov 07, 2016 5:43 pm

7 November progress update:

I've completely reworked the way fullscreen works, in order to fix the visible taskbar in Linux/OS X, as well as other bugs related to fullscreen.

That's all done, so fullscreen should work perfectly as of the next client update. You will then also have the ability to set up one fullscreen client per monitor. Example with two monitors:
Image


Furthermore, I have found the bug that caused several visual glitches (equipment appearing tiny & floating near your legs, incorrect animations, glitched boots and others) and fixed it. Took me a long time to find it, but eventually it came down to a single line of code that was very easily overlooked.

Lastly, I found the bug that caused some shops to not work at all (not being able to check the price of an item or buy an item), it was related to how pathing worked.


All of these will require a new client update to fix, so I'll postpone that until most of the other bugs have been fixed.

User avatar
Mike
Programmer
Posts: 6297
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Wed Nov 09, 2016 8:32 pm

DOUBLE POST! WOOOO. Im such a badass. Anyone else did this, they'd have gotten banned already fo'sure.


9 November progress update: managed to fix some more of the big bugs, one dupe (due to 1 word in the code I accidentally deleted - somehow) and I'm through the first 3 pages of bug reports on the news thread! I'm keeping a big to-do list with all the bugs, each of them marked by one of these 3 signs:
X (reported but not yet fixed or not yet looked into properly)
> (bug fixed)
- (already knew the bug beforehand or not a bug so no points awarded)


Points will be awarded later on, but I am keeping track of who reported what bug (for the first time - I don't keep track of re-reports).

Current list:
Spoiler: show
Factorial:
> Doesn't work on Linux (no points because no in-game name stated)


Saltyy
> Glitched equipment
> 'Store X' in bank does not work (does examine instead)
- 10x damage does not work (not yet implemented)


Im on meth
> Toolbar isn't hidden in fullscreen on Mac
> Crowns in right-click menu when adding friends
> Cannot use the PoH portal to enter a friend's house
X Opening display options closes bank pin screen


Demonwrider (Derrick46546)
> Cannot close the client except through task manager
> Vote store does not open


Slap a ho
> Brawling gloves cause invisibility (missing models)
X ::ss bugged
> Cannot properly interact with any NPC's
> Steadfast boots glitched (missing model)
> Cannot use tab to quick-reply
X Glitched marble staircase in dungeon
X Cannot remove NPC's from dungeon
> Glitched white tiles in the wilderness
X Dying in POH dungeon causes you to lose your items
X Cannot cut webs in wild
- Killing a monster drops all loot (intentional)
- Noclipping inside a PoH does not work (not yet implemented)
- Casting spells/attacking with ranged makes you walk all the way to the enemy (not yet implemented)


Matteh
> Steadfast boots glitched (missing model)


Floriduh
> Cannot use gnome agility log balance
> Cannot use wildy agility area stepping stones or log balance
X Royal items are bugged
X Cannot alch a lot of items

User avatar
Mike
Programmer
Posts: 6297
Joined: Sun Nov 01, 2009 8:00 pm
Location: PkHonor HQ

Re: Client upgrade - bugfix progress thread

Post by Mike » Thu Nov 10, 2016 10:46 pm

Triple kill!

Kinda surprising nobody has posted on my devblogs the past week, but I guess there's not much to say anyway :P nothing wrong with just watching dat progress anyway.


Current bughunter report (gone through the first 6 pages so far):
Spoiler: show
Factorial:
> Doesn't work on Linux (no points because no in-game name stated)


Saltyy
> Glitched equipment
> 'Store X' in bank does not work (does examine instead)
- 10x damage does not work (not yet implemented)


Im on meth
> Toolbar isn't hidden in fullscreen on Mac
> Crowns in right-click when adding friends
X Resizable mode doesn't show the full client (OS X only?)
> Cannot use the PoH portal to enter a friend's house
X Opening display options closes bank pin screen
> Picking up items off the ground doesn't remove them from the ground (visual, only applied to items with ID bigger than 32000)
> Changing modern tab area settings in Display options glitches your side panel when in fixed mode
> Logging on an account, logging off, and logging in on a new account causes friends list/ignore lists to merge for both accounts
X Cannot drop most items (untradeable)
- Modern healthbar option does not work (not yet implemented)
- At the ancient altar, you can only switch your spellbook to normal/ancient every couple of seconds (intended behavior, related to an old glitch ppl could abuse through spamclick)


Demonwrider (Derrick46546)
> Cannot close the client except through task manager
> Vote store does not open


Slap a ho
> Brawling gloves cause invisibility (missing models)
X ::ss bugged
> Cannot properly interact with any NPC's
> Steadfast boots glitched (missing model)
> Cannot use tab to quick-reply
X Glitched marble staircase in dungeon
X Cannot remove NPC's from dungeon
> Glitched white tiles in the wilderness
X Dying in POH dungeon causes you to lose your items
X Cannot cut webs in wild
- Killing a monster drops all loot (intentional)
- Noclipping inside a PoH does not work (not yet implemented)
- Casting spells/attacking with ranged makes you walk all the way to the enemy (not yet implemented)


Matteh
> Steadfast boots glitched (missing model)
> Cannot change morph ring NPC or add charges (all 2nd click or 3rd click on items with ID > 32000 was broken)


Floriduh
> Cannot use gnome agility log balance
> Cannot use wildy agility area stepping stones or log balance
X When losing HP to Rogues, the HP bar always appears red. Monsters seem to be fine. Explosive potions and overloads are fine.
X At Duel arena, accepting a duel crashes the interface. On top of this, the settings most likely work but do not show any check marks to alert players what has been selected
> Royal items are bugged
X Cannot alch a lot of items
X Check health on a tree does not work
- ::settings bugs your settings tab (not yet fully implemented, the command is going away)


Wir3d:
- Brightness adjustment does not work (not yet implemented)


Retsnom (Dead cats):
> 'Check steps' on any clue scroll (or WW scroll) makes you equip it
- You cannot light fires at a Player-Owned House or the skilling center (intended behavior), but you can use an inferno adze to light fires (also intended behavior). I might change this behavior, but it all works the same as on the production server, so either way no points are awarded.
- Mandrith, Nastroth and the Construction Expert chat heads show as Leprechaun (known bug, as stated on my original post)
- Boots of Darkness go to weapons slot (not yet implemented, we don't know yet when we'll add this)
- Type of damage is not shown (not yet implemented)
- No time limit between yells (intended testserver behavior)


Kahuna (Shadedice):
> Revenant/arrow clue scroll does not actually show an arrow
> You cannot close the revenant/arrow clue scroll interface

Srczm
Premium Donator
Posts: 32
Joined: Mon Sep 23, 2013 4:37 pm

Re: Client upgrade - bugfix progress thread

Post by Srczm » Thu Nov 10, 2016 11:32 pm

can you stop the triple posting please or i will file a complaint thank you randomer

User avatar
Tezey
Honor Player
Posts: 1677
Joined: Thu Jul 03, 2014 7:13 pm
Location: Sweden

Re: Client upgrade - bugfix progress thread

Post by Tezey » Fri Nov 11, 2016 1:06 pm

Mike wants to hear what an awesome job he is doing :badjokeeel: :LOL:
Image

User avatar
Jonas
Fanatic
Posts: 4920
Joined: Mon Aug 26, 2013 8:50 pm
Location: Lithuania.

Re: Client upgrade - bugfix progress thread

Post by Jonas » Fri Nov 11, 2016 2:43 pm

You're doing great!
Image

Locked